[Mesa-dev] [PATCH] Enable display list support for glClearBuffer functions

[Ian Romanick]

On 12/13/2011 12:01 PM, Anuj Phogat wrote:
> Enabling display list support for glClearBuffer functions with minor fixes

There's also a #if 0 block in that file that should be removed.  This is 
a case where 'git blame' is useful.  doing 'git blame 
src/mesa/main/dlist.c' shows that all of those lines were added in 
commit 05fb922e.  Looking at commit 05fb922e shows the #if 0 block.

> Signed-off-by: Anuj Phogat<anuj.phogat at gmail.com>
> ---
> Tested this patch with a newly developed piglit testcase (clearbuffer-display-list).
> Please refer to piglit mailing list for testcase patch.
>
>   src/mesa/main/dlist.c |   22 +++++++++++-----------
>   1 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c
> index e1acc80..b3edae0 100644
> --- a/src/mesa/main/dlist.c
> +++ b/src/mesa/main/dlist.c
> @@ -1422,7 +1422,7 @@ save_ClearBufferiv(GLenum buffer, GLint drawbuffer, const GLint *value)
>         }
>      }
>      if (ctx->ExecuteFlag) {
> -      /*CALL_ClearBufferiv(ctx->Exec, (buffer, drawbuffer, value));*/
> +      CALL_ClearBufferiv(ctx->Exec, (buffer, drawbuffer, value));
>      }
>   }
>
> @@ -1450,7 +1450,7 @@ save_ClearBufferuiv(GLenum buffer, GLint drawbuffer, const GLuint *value)
>         }
>      }
>      if (ctx->ExecuteFlag) {
> -      /*CALL_ClearBufferuiv(ctx->Exec, (buffer, drawbuffer, value));*/
> +      CALL_ClearBufferuiv(ctx->Exec, (buffer, drawbuffer, value));
>      }
>   }
>
> @@ -1478,7 +1478,7 @@ save_ClearBufferfv(GLenum buffer, GLint drawbuffer, const GLfloat *value)
>         }
>      }
>      if (ctx->ExecuteFlag) {
> -      /*CALL_ClearBufferuiv(ctx->Exec, (buffer, drawbuffer, value));*/
> +      CALL_ClearBufferfv(ctx->Exec, (buffer, drawbuffer, value));
>      }
>   }
>
> @@ -1498,7 +1498,7 @@ save_ClearBufferfi(GLenum buffer, GLint drawbuffer,
>         n[4].i = stencil;
>      }
>      if (ctx->ExecuteFlag) {
> -      /*CALL_ClearBufferfi(ctx->Exec, (buffer, drawbuffer, depth, stencil));*/
> +      CALL_ClearBufferfi(ctx->Exec, (buffer, drawbuffer, depth, stencil));
>      }
>   }
>
> @@ -7545,36 +7545,36 @@ execute_list(struct gl_context *ctx, GLuint list)
>               break;
>            case OPCODE_CLEAR_BUFFER_IV:
>               {
> -               /*GLint value[4];
> +               GLint value[4];
>                  value[0] = n[3].i;
>                  value[1] = n[4].i;
>                  value[2] = n[5].i;
>                  value[3] = n[6].i;
> -               CALL_ClearBufferiv(ctx->Exec, (n[1].e, n[2].i, value));*/
> +               CALL_ClearBufferiv(ctx->Exec, (n[1].e, n[2].i, value));
>               }
>               break;
>            case OPCODE_CLEAR_BUFFER_UIV:
>               {
> -               /*GLuint value[4];
> +               GLuint value[4];
>                  value[0] = n[3].ui;
>                  value[1] = n[4].ui;
>                  value[2] = n[5].ui;
>                  value[3] = n[6].ui;
> -               CALL_ClearBufferiv(ctx->Exec, (n[1].e, n[2].i, value));*/
> +               CALL_ClearBufferuiv(ctx->Exec, (n[1].e, n[2].i, value));
>               }
>               break;
>            case OPCODE_CLEAR_BUFFER_FV:
>               {
> -               /*GLfloat value[4];
> +               GLfloat value[4];
>                  value[0] = n[3].f;
>                  value[1] = n[4].f;
>                  value[2] = n[5].f;
>                  value[3] = n[6].f;
> -               CALL_ClearBufferfv(ctx->Exec, (n[1].e, n[2].i, value));*/
> +               CALL_ClearBufferfv(ctx->Exec, (n[1].e, n[2].i, value));
>               }
>               break;
>            case OPCODE_CLEAR_BUFFER_FI:
> -            /*CALL_ClearBufferfi(ctx->Exec, (n[1].e, n[2].i, n[3].f, n[4].i));*/
> +            CALL_ClearBufferfi(ctx->Exec, (n[1].e, n[2].i, n[3].f, n[4].i));
>               break;
>            case OPCODE_CLEAR_COLOR:
>               CALL_ClearColor(ctx->Exec, (n[1].f, n[2].f, n[3].f, n[4].f));