[Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

[Eric Anholt]

On Tue, 13 Dec 2011 18:07:05 -0700, Brian Paul <brian.e.paul at gmail.com> wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> This fixes two things:
> 1. If the texture object was created with glTexStorage2D, the call
>    to _mesa_TexImage2D() would generate INVALID_OPERATION since the
>    texture is marked as immutable.
> 2. _mesa_TexImage2D() always frees any existing texture image memory
>    before allocating new memory.  That's inefficient since the existing
>    image is usually the right size already.  Now we only make the call
>    when necessary.
> 
> v2: use _mesa_TexImage() in prepare_dest_image() to make sure side-effects
> of changing a texture image are observed (like FBO completeness).

Should this live in main/mipmap.c?  It looks like
generate_mipmap_uncompressed() needs it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111214/a22b6036/attachment.pgp>