[Mesa-dev] vertex array regression

[Mathias Fröhlich]

Brian,

On Monday, December 19, 2011 17:01:07 you wrote:
> I still don't get what the purpose of the special mapping of the last
> four/five elements is all about.  Can you explain that?

As far as I can see the last ones should not map to anything.
The map is used only in fixed function mode. And there these arrays should not 
show up as inputs to any fixed function shader. I think that the purpose of the 
previous mapping was just to fill in anything. The changes I did serve exactly 
this purpose.

But I agree that here should not be any mapping of these attributes in this 
mode. Attached is a small change that is probably a more clean solution to 
this mapping problem.

The change passes a quick r600g piglit test.

> Yeah, I see how the incorrect varying_inputs values was causing
> _NEW_ARRAY to get set, thus hiding the problem.  The solution looks
> correct, but I'm a little worried about performance, as is mentioned
> in the comment.
> 
> Marek, made that change back in March.  Maybe he can take a look at
> this too.
I cannot comment on this, since I do not see a performance regression on my 
use cases.
Marek?

Greetings

Mathias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vbo-Set-unused-arrays-in-fixed-function-mode-to-inva.patch
Type: text/x-patch
Size: 2362 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111219/345e9d36/attachment.bin>