[Mesa-dev] [PATCH] mesa: remove stray GL_TEXTURE_1D_ARRAY code in _mesa_store_teximage3d()

[Brian Paul]

On 12/19/2011 02:56 PM, Eric Anholt wrote:
> On Mon, 19 Dec 2011 13:47:42 -0700, Brian Paul<brianp at vmware.com>  wrote:
>> GL_TEXTURE_1D_ARRAY is never a legal target for glTexImage3D.  This was
>> probably copy&paste code from the _mesa_store_teximage2d() function above.
>
> Radeon and intel use texstore3d for all our TexImage* storage.  Though
> it does look like we could dump our 1D and 3D overrides of 1D and 3D,
> and then use texstore2d.

OK, I'll leave that as-is for now.  There should probably be a comment 
explaining what's going on there.

I found this when I was looking at consolidating the texstore code.  I 
think that all six variations of 1D/2D/3D whole/sub-image could be 
consolidated into one function.  I'll see if I can finish that up tonight.

-Brian