[Mesa-dev] [PATCH] ff_fragment_shader: Don't generate swizzles for scalar combiner inputs

Eric Anholt eric at anholt.net
Fri Dec 23 22:35:18 PST 2011

On Thu, 22 Dec 2011 17:43:57 -0800, "Ian Romanick" <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
> There are a couple scenarios where the source could be zero and the
> operand could be either SRC_ALPHA or ONE_MINUS_SRC_ALPHA.  For
> example, if the source was ZERO.  This would result in something like
> (0).w, and a later call to ir_validate would get angry.
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=42517

In other cases of handling this in the code, I was using the little
smear() helper function.  I'd tend towards using that here as well, but
no strong feeling.

There's also a "bump = get_source(...)" in the bumpmap handling that
looks like it could use the same treatment.

I think I've reviewed all the other swizzles in the code now.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111223/e0af7a97/attachment.pgp>

More information about the mesa-dev mailing list