[Mesa-dev] [PATCH 2/2] i965: Create mock implementation of GL_OES_EGL_image_external

[Eric Anholt]

On Wed, 21 Dec 2011 18:34:19 -0800, Chad Versace <chad.versace at linux.intel.com> wrote:
> In Android IceCreamSandwich, SurfaceFlinger requires GL_OES_image_external
> for basic compositing tasks. Without the extension, SurfaceFlinger fails
> to start.
> 
> Despite the incompleteness of the extension's implementation introduced by
> this patch, it is good enough to enable SurfaceFlinger and to unblock the
> people who need to begin testing Mesa on IceCreamSandwich.
> 
> To enable the extension, set the environment variable
> MESA_EXTENSION_OVERRIDE="+GL_OES_EGL_image_external". Ideally, Android
> should set this in init.rc.
> 
> WARNING: This implementation of GL_OES_EGL_image_external is not complete.
> Some of it is even incorrect. When we begin to really implement
> GL_OES_EGL_image_external, much of the patch will need reverting.
> 
> Signed-off-by: Chad Versace <chad.versace at linux.intel.com>

> diff --git a/src/mesa/drivers/dri/intel/intel_tex_image.c b/src/mesa/drivers/dri/intel/intel_tex_image.c
> index dd0c6d3..cdb7b1e 100644
> --- a/src/mesa/drivers/dri/intel/intel_tex_image.c
> +++ b/src/mesa/drivers/dri/intel/intel_tex_image.c
> @@ -39,6 +39,7 @@ intel_miptree_create_for_teximage(struct intel_context *intel,
>     GLuint lastLevel;
>     int width, height, depth;
>     GLuint i;
> +   GLenum target = intelImage->base.Base.TexObject->Target;

How about just poking at intelObj->Base.Target?

Other than that,

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111224/54167273/attachment.pgp>