[Mesa-dev] [PATCH 21/22] swrast: stop using _DepthBuffer in triangle code

[Eric Anholt]

On Thu, 22 Dec 2011 10:43:57 -0700, Brian Paul <brian.e.paul at gmail.com> wrote:
> On Wed, Dec 21, 2011 at 2:16 PM, Eric Anholt <eric at anholt.net> wrote:
> > On Sun, 18 Dec 2011 20:08:26 -0700, Brian Paul <brianp at vmware.com> wrote:
> >> The only consequence is we can only use the occlusion_zless_16_triangle()
> >> function with MESA_FORMAT_Z16.
> >
> > I'm not following that conclusion, probably due to ignorance of swrast
> > spans code.  I would think that Z32 would still work for that other path
> > -- or is span.z stored as something other than 32 bits of Z in that
> > case, too?
> 
> Z32 would still work, but in practice that format of depth buffer is
> seldom used with swrast.  Z16 is the default.  I was tempted to remove
> the function entirely.

I'd love a commit message rewording to that extent -- I spent a while
trying to puzzle through it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20111224/6528c67a/attachment.pgp>