[Mesa-dev] [PATCH] vbo: signal _NEW_ARRAY when transitioning between glBegin/End, glDrawArrays

Mathias Fröhlich Mathias.Froehlich at gmx.net
Sun Dec 25 13:08:12 PST 2011


Hi Brian,

On Saturday, December 24, 2011 16:38:09 Brian Paul wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> This fixes a regression seen with the isosurf demo when switching between
> glBegin/End and glDrawArrays (do it several times).  The problem was the
> driver wasn't getting _NEW_ARRAY when the arrays were subtly changed:
> (vertex3f, normal3f) vs. (normal3f, vertex3f).
> 
> This patch fixes that by signaling _NEW_ARRAY whenever we transition
> between glBegin/End and glDrawArrays mode and display lists.
> 
> The patch also fixes up the initialization of the map_vp_none[] array
> to stop putting strange values in the last five elements of the array.
> 
> v2: remove DRAW_ELEMENTS, don't distinguish between glDrawArrays and
> glDrawElements
> 
> v3: add DRAW_DISPLAY_LIST for the display list case, just to be safe.

Reviewed and tested by: Mathias.Froehlich at web.de
... survives a piglit r600 regression run and fixes isosurf.

Happy Christmas Days!!

Mathias


More information about the mesa-dev mailing list