[Mesa-dev] [PATCH] vbo: Clean up recalculate_input_bindings.

[Brian Paul]

2011/12/27 Mathias Fröhlich <Mathias.Froehlich at gmx.net>:
>
> Hi,
>
> On Tuesday, December 27, 2011 00:17:09 Brian Paul wrote:
>> LGTM.  I presume you've done a piglit run and tested with a few other
>> things?
> I have run piglit quick with classic swrast an piglit r600g on gallium rv670
> with this change. Also I am pretty sure that I have started osgviewer and
> probably flightgear on this. The full piglit runs are just too heavy running
> with valgrind. I never had the patience to wait for that to finish.
>
> So, I have leared from the past series that classic swrast serves as a good
> testbed for tnl drivers like the intel one - where I do not have hardware at
> hand. I did not do this in former times.
> In this case the swrast test is probably my best bet to catch changes in the
> classic paths anyway.
>
> When we are at this, what tests would you recommend?

It sounds like you ran enough of piglit to catch any likely regression.

-Brian