[Mesa-dev] [PATCH 1/4] mesa: simplify Driver.TexSubImage() parameters

[Chad Versace]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/26/2011 03:09 PM, Brian Paul wrote:
> From: Brian Paul <brianp at vmware.com>
> 
> There's no need to pass the target, level and texObj parameters since
> they can be easily obtained from the texImage pointer.
> ---
>  src/mesa/drivers/common/meta.c                  |   18 +++++-----
>  src/mesa/drivers/dri/intel/intel_tex_subimage.c |   31 ++++++----------
>  src/mesa/drivers/dri/nouveau/nouveau_texture.c  |   45 +++++++++++------------
>  src/mesa/main/dd.h                              |   44 +++++++++++------------
>  src/mesa/main/mipmap.c                          |    5 +--
>  src/mesa/main/teximage.c                        |   15 +++-----
>  src/mesa/main/texstore.c                        |   21 +++++------
>  src/mesa/main/texstore.h                        |   21 +++++------
>  8 files changed, 89 insertions(+), 111 deletions(-)

I didn't review everything, since much of the change was mechanical.
A clean build with the patches applied didn't generate additional warnings,
so I assume all is good with this series.

For the series,
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

- ----
Chad Versace
chad.versace at linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJO+gfpAAoJEAIvNt057x8ioioP/2Gl1GgpZXZ1bvwYOTEBMsgo
hyoOPYaXKbY97HJWMCglqdLUSB6WVQREa/HFErT1G+0TW77PaM3ypnuONTKB15gZ
XyWwqV/TrEsda1Ibydu+fI2wduGy2Pac18MASsWD6vIIJuSKdcS5mjnyFagtJ+BH
eTevdwBXX635siStp46kmIalRZ2xWTRMalzDD6RANB/JaZ4giEB6q3YSbMlW8TKw
g03J1K53njltEq0IYjgjOynmsJhnu1AK98511ttLQxwKxuG5tuSrBkU4ncDkWlJF
QoT7pRBN84zIrUCHPrrUOVnzN0ec8ieuIFlsJOFone8CfJs28sDKdWOl8Ou39Sl0
RQPhAriwHrEYUvXUWnVxVAUPUC0c9VkQGzFVAQqUvAJn6FEAxQmyXk0DS+GOm6kk
5q3W5kxwh0hx+MMRpKjt4X/w/B177WbVa2DMFWzlXy536ignPESJm2bzBMUFEkd7
gNYOHIIo+s0KBdG8dEHFSlGiMDyxTPaODKJG1PgWjcQ71r9OgrfjClxfvx8C0CMC
N43INvqSD4BCFGuPYdXITncd2oshJtTQiTYdRYALiqgjs24VoGXLS3o0M9l7RKHt
3UCG05jcJxuZOZS+qd4yZloayealzsrn1qJz753RCgo+R6w2GZSs13TaT1TbFTYN
njLC4flMlHVJxmScKU93
=+MGV
-----END PGP SIGNATURE-----