[Mesa-dev] [PATCH 2/2] i965: fix the wrong min/max_index for nr_prims > 1

[Michel Dänzer]

On Don, 2011-12-29 at 10:03 +0800, Yuanhan Liu wrote: 
> On Wed, Dec 28, 2011 at 12:07:08PM -0800, Eric Anholt wrote:
> > On Wed, 28 Dec 2011 13:54:43 +0800, Yuanhan Liu <yuanhan.liu at linux.intel.com> wrote:
> > > The current code would just calculate min/max_index for the first prim
> > > unconditionally, which is wrong if nr_prims > 1.
> > > 
> > > This would some cases like that the index is stored in element array
> > > buffer object and drawing by glMultiDrawEelements. Thus it fixes some
> > > intel oglc primbuff test cases.
> > > 
> > > Signed-off-by: Yuanhan Liu <yuanhan.liu at linux.intel.com>
> > 
> > It does look like gallium has the same bug --
> 
> i965g?  I just found that the whole i965g is deleted by commit
> 2c27f204f1ca6f09f9520712be1da9a13ed5c01d.
> 
> > this should probably be a
> > vbo helper function.
> 
> If you were talking about i965g and now it was deleted, should I make
> this be a vbo helper function?

i965g was just one Gallium driver. Presumably, Eric was referring to the
Gallium Mesa state tracker (src/mesa/state_tracker/), which translates
between the Mesa and Gallium driver interfaces.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer