[Mesa-dev] [PATCH] Define GLX_USE_TLS when the user asks for TLS.

[tom fogal]

Chia-I Wu <olvaffe at gmail.com> writes:
> On Mon, Feb 21, 2011 at 8:12 PM, Tom Fogal <tfogal at sci.utah.edu> wrote:
> > From: Tom Fogal <tfogal at alumni.unh.edu>
> >
> > Without this, we do not actually respect the request for TLS.
>
> What is your setup?

    ./configure                           \
        CFLAGS="-g -DUSE_MGL_NAMESPACE"   \
        CXXFLAGS="-g -DUSE_MGL_NAMESPACE" \
        --prefix=${PF}                    \
        --without-demos                   \
        --with-driver=xlib                \
        --disable-gallium                 \
        --disable-egl                     \
        --with-max-width=16384            \
        --with-max-height=16384           \
        --enable-glx-tls

Others are hitting this too:

  http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg05292.html

Note I was wrong in that email, it was not an x86-only issue.

> The macro should be defined as part of $(CFLAGS).  It may not be a
> good practice as the variable is normally considered a user variable,
> but mesa does not quite support that.

So is the correct fix to check the flag in configure.ac and append the
define there?

AHHH-ha!  I think I see the problem.  We were only applying the flags
if users were doing DRI builds.

I'll apply the attached in a day or so, unless I hear some complaints.
Thanks!

-tom

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: text/x-diff
Size: 687 bytes
Desc: mesa.diff
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110221/afabdc83/attachment-0001.diff>