[Mesa-dev] [PATCH 3/4] dri2: Don't call the dri2 flush hook for swapbuffers unless we have a context.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 02/22/2011 12:07 PM, Kristian Høgsberg wrote:
> It looks like there could be a problem if the drawable isn't current
> for any context, and Erics patch looks like it just skips it if
> there's no current context which probably fixes some crashes.  It
> seems like it could still crash if there's a current context, but the
> drawable passed to swapbuffers isn't current for any context.  The
> spec says that the flush is only implied if the drawable is current
> for the current context in the current thread, maybe we just need to
> add that check before calling the dri flush entrypoint.

It should be easy enough to generate tests for those cases.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1kQXsACgkQX1gOwKyEAw84pACfeC2f7j5o3KOe8SDc9ajcVID+
xscAn1PxL4YrcACYf0QHYsGHhvHyZU6W
=AwXG
-----END PGP SIGNATURE-----