[Mesa-dev] [PATCH 1/1] st/mesa: Set samplers views' first_level.

[Brian Paul]

On 01/13/2011 03:55 AM, Henri Verbeet wrote:
> On 4 January 2011 22:05, Henri Verbeet<hverbeet at gmail.com>  wrote:
>> Base level and min LOD aren't equivalent. In particular, min LOD has no
>> effect on image array selection for magnification and non-mipmapped
>> minification.
>> ---
>>   src/mesa/state_tracker/st_atom_sampler.c |    9 +++------
>>   src/mesa/state_tracker/st_atom_texture.c |    4 +++-
>>   2 files changed, 6 insertions(+), 7 deletions(-)
>>
> Did this get lost? Otherwise I'll probably push this sometime during
> the next few days.



This isn't fresh in my head any more, but the code as-is matches the 
behaviour of NVIDIA's driver (and fixed a mipmap failure in a test 
somewhere).  The mesa-demos/src/tests/mipmap_limits test is good for 
testing this.

I applied your patch and now mipmap_limits no longer matches NVIDIA.

I don't have time right now to dig into this.  Does your patch fix 
something in particular?

-Brian