[Mesa-dev] Mesa (master): i965: Remove unnecessary headers.

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/13/2011 10:59 AM, Vinson Lee wrote:
>> -----Original Message-----
>> From: mesa-dev-bounces+vlee=vmware.com at lists.freedesktop.org [mailto:mesa-
>> dev-bounces+vlee=vmware.com at lists.freedesktop.org] On Behalf Of Ian
>> Romanick
>> Sent: Thursday, January 13, 2011 10:43 AM
>> To: mesa-dev at lists.freedesktop.org
>> Subject: Re: [Mesa-dev] Mesa (master): i965: Remove unnecessary headers.
>>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 01/13/2011 09:29 AM, Vinson Lee wrote:
>>> Module: Mesa
>>> Branch: master
>>> Commit: 1f6693033256123ec5cf6f186e5cfb1679e523d3
>>> URL:
>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f6693033256123ec5cf6f186
>> e5cfb1679e523d3
>>>
>>> Author: Vinson Lee <vlee at vmware.com>
>>> Date:   Thu Jan 13 09:28:47 2011 -0800
>>>
>>> i965: Remove unnecessary headers.
>>
>> Does this actually provide any tangible benefit to anyone?  All of the
>> spurious header file frobbing has caused several irritations for me, at
>> least:
>>
>> 1. Some commonly used things, like MIN2, MAX2, and ELEMENTS, have moved.
>>  This causes frustration when writing new code.
>>
>> 2. The changes cause massive invalidations of my compiler cache.  As a
>> result, my average build times are longer.  I can only assume that the
>> perceived benefit of all these changes is reduced build time.
>>
>> If there's no benefit, it just feels like spam.
> 
> The purpose is to reduce build times and improve throughput in automated testing.

For everyone on a modern system with a caching compiler it is having the
opposite effect.  Optimizing the build for automated testing (as opposed
to optimizing it for development) is the tail wagging the dog.  Unless
you're making other, *useful* changes to the files at the same time,
stop making these kinds of changes.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0wlEUACgkQX1gOwKyEAw/CKgCgkBpMXD69QGnZmreKEhfuEPCZ
zx0AnRJjVcabAs3acUTeiAl2IGjqC95d
=0UGf
-----END PGP SIGNATURE-----