[Mesa-dev] [Bug 33433] New: .type directives in glapi_x86.S miss required @ character

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33433

           Summary: .type directives in glapi_x86.S miss required @
                    character
           Product: Mesa
           Version: git
          Platform: x86 (IA32)
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Mesa core
        AssignedTo: mesa-dev at lists.freedesktop.org
        ReportedBy: dimitry at andric.com


Created an attachment (id=42410)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=42410)
Add @ char before type specifier

While building Mesa with the trunk version of clang, using its
integrated assembler, it complains about the .type directives in
glapi_x86.S:

clang -c -I. -I../../../include -I../../../include/GL/internal
-I../../../src/mesa -I../../../src/mesa/glapi -I/usr/local/include
-I/usr/local/include/drm   -I/usr/local/include   -D_THREAD_SAFE
-I/usr/local/include   -I/usr/local/include -O2 -pipe -fno-strict-aliasing
-Wall -Wmissing-prototypes -std=c99 -ffast-math -fno-strict-aliasing  -fPIC 
-DUSE_X86_ASM -DUSE_MMX_ASM -DUSE_3DNOW_ASM -DUSE_SSE_ASM -DHAVE_POSIX_MEMALIGN
-DUSE_XCB -DPTHREADS -DUSE_EXTERNAL_DXTN_LIB=1 -DIN_DRI_DRIVER -DHAVE_ALIAS
-DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DXF86VIDMODE -D_REENTRANT
-UIN_DRI_DRIVER -DDEFAULT_DRIVER_DIR=\"/usr/local/lib/dri\" 
../../../src/mesa/x86/glapi_x86.S -o ../../../src/mesa/x86/glapi_x86.o
/tmp/cc-vj1ww7.s:30:50: error: expected '@' or '%' before type
 .balign 16; .globl glNewList ; .type glNewList, function; glNewList: movl
_glapi_Dispatch,%eax ; testl %eax,%eax ; je 1f ; jmp *4 * 0(%eax) ; 1: call
_x86_get_dispatch ; jmp *4 * 0(%eax)
                                                 ^

These .type directives are expanded from the GLOBL_FN macro in the same
file:

#define GLOBL_FN(x) GLOBL x ; .type x, function

However, the actual type specifier following the comma should normally
be preceded by an '@' character.  For reference, see the binutils
documentation about the .type directive here:

  http://sourceware.org/binutils/docs/as/Type.html

Most of the other .S files in Mesa also use an '@' character, so I would
like to propose to do the same here, for portability between assemblers.
Since this particular .S file seems to be generated from gl_x86_asm.py,
I have also updated that script to match.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.