[Mesa-dev] [PATCH] util: require debug options to be separated by commas

Brian Paul brian.e.paul at gmail.com
Tue Jan 25 19:28:21 PST 2011


On Mon, Jan 24, 2011 at 9:52 PM, Marek Olšák <maraeo at gmail.com> wrote:
> Let's assume there are two options with names such that one is a substring
> of another. Previously, if we only specified the longer one as a debug option,
> the shorter one would be considered specified as well (because of strstr).
> This commit fixes it by checking that each option is surrounded by commas.
>
> (a regexp would be nicer, but this is not a performance critical code)

Looks good to me.

-Brian


More information about the mesa-dev mailing list