[Mesa-dev] Mesa (master): mesa: fix compilation

Jose Fonseca jfonseca at vmware.com
Thu Jan 27 00:01:15 PST 2011

Hi Chad,

The least common denominator we're trying to target is MSVC, which doesn't support most of C99 till date.

We could add -Werror=declaration-after-statement but only in the shared components (ie., src/mesa, src/gallium/auxiliary) but not src/mesa/drivers & src/gallium/drivers as there many drivers for which will most likely never be supported on Windows, so there is no reason to stop using C99.


From: mesa-dev-bounces+jfonseca=vmware.com at lists.freedesktop.org [mesa-dev-bounces+jfonseca=vmware.com at lists.freedesktop.org] On Behalf Of Zack Rusin [zackr at vmware.com]
Sent: Thursday, January 27, 2011 3:16
To: Chad Versace
Cc: mesa-dev at lists.freedesktop.org
Subject: Re: [Mesa-dev] Mesa (master): mesa: fix compilation

On Wednesday 26 January 2011 21:49:56 Chad Versace wrote:
> What I wrote *isn't* C++. It's valid C99. It compiles without problem
> with both GCC 4.5 and Clang 2.8 on Fedora14.
> What compiler are you using? And why can't it handle a C dialect over a
> decade old?

It doesn't matter which compiler I use because we explicetly make sure that
this particular feature is off (you can always grep for -Werror=declaration-
after-statemant to double-check). Both make and scons builds do that and those
are the only build systems we use. You can use either one to verify. For
better or worse we use compile flags that give us straight out of the box
portability across platforms (in particular windows) and while it might change
soon for now it is the way it is.

> My patches frequently break VMWare's builds, and a VMWare member "fixes"
> my patches every time. I want to find a permanent fix for this.

Yes, that'd be good.

mesa-dev mailing list
mesa-dev at lists.freedesktop.org

More information about the mesa-dev mailing list