[Mesa-dev] [PATCH] ir_to_mesa: fix copy propagation
Christoph Bumiller
e0425955 at student.tuwien.ac.at
Thu Jan 27 14:40:04 PST 2011
On 27.01.2011 23:20, Ian Romanick wrote:
> On 01/26/2011 04:30 AM, Christoph Bumiller wrote:
> > The current copy propagation code would propagate TEMP[0].x from (6)
> > into TEMP[1].x from (8) in the following, which is clearly wrong:
>
> > 6: MOV TEMP[1].x, TEMP[0].xxxx
> > 7: MOV TEMP[0].x, TEMP[0].yyyy
> > 8: MOV TEMP[0].y, TEMP[1].xxxx
> > 9: ADD TEMP[1].x, TEMP[0].zzzz, IMM[0].yyyy
> > 10: MOV TEMP[0].z, TEMP[1].xxxx
>
> > Possible patch and a small program to check this attached.
> > Tested with llvmpipe.
>
> Does this fix https://bugs.freedesktop.org/show_bug.cgi?id=33197? This
> is reproducible with piglit test case glsl-vs-post-increment-01.
Oops, your were faster, I just sent a shader_runner test as well after I
realized that that's what you actually wanted.
Anyway, the copy propagation patch does not fix glsl-vs-post-increment-01.
Christoph
More information about the mesa-dev
mailing list