[Mesa-dev] Mesa (master): glcpp: Demote "macro redefined" from an error to a warning

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/27/2011 09:16 PM, Carl Worth wrote:
> Module: Mesa
> Branch: master
> Commit: d3df641f0aba99b0b65ecd4d9b06798bca090a29
> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d3df641f0aba99b0b65ecd4d9b06798bca090a29
> 
> Author: Carl Worth <cworth at cworth.org>
> Date:   Mon Aug 23 11:38:45 2010 -0700

Given the date on this commit, I'm going to assume that you pushed this
by mistake.  We decided months ago that this test case was just plain
wrong, and we removed it from the test list.  Could you please revert
this commit?

> glcpp: Demote "macro redefined" from an error to a warning
> 
> The GLSL specification is vague here, (just says "as is standard for
> C++"), though the C specifications seem quite clear that this should
> be an error.
> 
> However, an existing piglit test (CorrectPreprocess11.frag) expects
> this to be a warning, not an error, so we change this, and document in
> README the deviation from the specification.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1C8e8ACgkQX1gOwKyEAw+QhQCghRJ3w7qiIOtIi3a/GyYz3y7l
rIQAn3fvw3pfm/3rHrB+I+RFuMdlV4ZY
=GB0c
-----END PGP SIGNATURE-----