[Mesa-dev] [PATCH] mesa: Set -Werror=declaration-after-statement in mesa/Makefile
brian.e.paul at gmail.com
Fri Jan 28 14:27:05 PST 2011
On Fri, Jan 28, 2011 at 3:15 PM, Chad Versace <chad at chad-versace.us> wrote:
> On 01/28/2011 01:03 PM, Brian Paul wrote:
>> I think this should be done up in the configure.ac file. Otherwise
>> we're assuming gcc in the Makefile.
> I was attempting to limit this change to files within core mesa.
> Setting this option globally breaks the Intel driver build, because
> those drivers use C99. For GCC builds, configure.ac explicitly sets
> --std=c99. See thread: "Mesa (master): mesa: fix compilation".
> I am no Makefile or autoconf expert, so I see no other way to do this.
Couldn't we just define something like CORE_MESA_ERROR_FLAGS in
configure.ac and only use it in src/mesa/Makefile? I don't think the
DRI driver Makefile.template inherits anything from src/mesa/Makefile.
I'm not an autoconf expert either.
More information about the mesa-dev