[Mesa-dev] more EXT_framebuffer_sRGB, 965 support

Brian Paul brianp at vmware.com
Mon Jan 31 08:12:09 PST 2011


On 01/27/2011 09:34 PM, Dave Airlie wrote:
> Okay looking for some review/comments, esp on the addition to the
> ctx->Const structure to denote if sRGB on FBOs is possible.
>
> Since just enabling the extension doesn't mean anything, we should
> probably enable it on anything that enables EXT_texture_sRGB.

I'm not sure.  What's the value in enabling an extension that doesn't 
do something useful?

The extension spec says "Implementations are encouraged to allow sRGB 
update and blending when rendering to sRGB textures using 
ARB_framebuffer_object but this is not required."

I guess I'd rather implement what's suggested than just enabling a 
no-op extension.

The patch looks fine.

-Brian


More information about the mesa-dev mailing list