[Mesa-dev] [PATCH 11/13] gallium/util: implement pack functions for Z32F and Z32F_S8X24

Keith Whitwell keithw at vmware.com
Fri Jul 1 05:53:14 PDT 2011


On Fri, 2011-07-01 at 14:42 +0200, Marek Olšák wrote:
> On Fri, Jul 1, 2011 at 10:49 AM, Keith Whitwell <keithw at vmware.com> wrote:
> > On Fri, 2011-07-01 at 02:29 +0200, Marek Olšák wrote:
> >> The suffix of 64 means it returns uint64_t.
> >
> > It might be slightly clearer to call these functions util_pack64_{xxx}
> > -- currently it reads as if it is packing 64-bit source data.
> 
> Yeah, that's nicer. Here's the diff I am going to squash with the
> patches 11 and 12.

Looks great!

Keith



More information about the mesa-dev mailing list