[Mesa-dev] [PATCH 00/13] Floating-point depth buffers

[Brian Paul]

On Wed, Jul 6, 2011 at 10:43 PM, Marek Olšák <maraeo at gmail.com> wrote:
> On Wed, Jul 6, 2011 at 5:49 PM, Brian Paul <brianp at vmware.com> wrote:
>> On 06/30/2011 06:29 PM, Marek Olšák wrote:
>>>
>>> Hi,
>>>
>>> this patch series implements ARB_depth_buffer_float in Mesa and Gallium.
>>> There is complete r600g/r600-r700 support in my private branch, which passes
>>> the same tests that pass for Z24S8. Softpipe has only sampler support. This
>>> has turned out to be not so trivial, so it's possible I missed something.
>>>
>>> I did not implement NV_depth_buffer_float, because it's not compatible
>>> with the ARB variant. (GL_DEPTH_COMPONENT32F != GL_DEPTH_COMPONENT32F_NV
>>> etc.) The NV extension can operate on unclamped depth values, whereas the
>>> ARB one always clamps them.
>>>
>>> Please review.
>>
>> I took a quick look at the patches and they look good to me.
>>
>> I saw some piglit updates for these formats.  Do we have pretty good
>> coverage or is more needed?
>
> There is much more needed. Especially these could use some more testing:
>
> mesa: implement texfetch functions for depth_buffer_float
> mesa: implement stencil unpacking for GL_FLOAT_32_UNSIGNED_INT_24_8_REV
> mesa: implement depth unpacking for GL_FLOAT_32_UNSIGNED_INT_24_8_REV
> mesa: implement texstore for DEPTH32F_STENCIL8 (the slow path)
> mesa: implement depth/stencil renderbuffer wrapper accessors for
> Z32F_X24S8 (no sure how to test this on Gallium)
> gallium/util: implement software Z32F_S8X24 depth-stencil clear
>
> Moreover, all the stencil drawpixels and copypixels tests were failing
> with any format on softpipe and r600g when I tried it.

I committed some fixes to fbo-stencil yesterday that help with
softpipe.  Might help with r600g too.

-Brian