[Mesa-dev] [PATCH] glsl: Reject ambiguous function calls (multiple inexact matches).

[Eric Anholt]

On Sat,  9 Jul 2011 01:56:19 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> According to the GLSL 1.20 specification, "it is a semantic error if
> there are multiple ways to apply [implicit] conversions [...] such that
> the call can be made to match multiple signatures."
> 
> Fixes a regression caused by 60eb63a855cb89962f2d5bb91e238ff2d1ab8702,
> which implemented the wrong policy of finding a "closest" match.
> However, this is not a revert, since the original code failed to
> continue looking for an exact match once it found two inexact matches.
> 
> It's OK to have multiple inexact matches if there's also an exact match.
> 
> NOTE: This is a candidate for the 7.10 and 7.11 branches.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=38971
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110710/0c0c986e/attachment.pgp>