[Mesa-dev] [Bug 38842] Various valid GLX attributes are rejected by MESA glxChooseFBConfig

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38842

--- Comment #9 from Jonathan Kirkham <jonathan.kirkham at arm.com> 2011-07-11 00:55:03 PDT ---
(In reply to comment #8)
> (In reply to comment #7)
> > The attributes are valid for glxChooseFBConfig, the attributes and their values
> > are just ignore by it.
> > 
> > Returning NULL in choose_visual causes glxConfigFBConfig to also return NULL
> > which is incorrect, it should return the list of valid configs. Passing in
> > these ignored attributes should not alter the configs returned by
> > glxChooseFBConfig.
> 
> Note that the 'fbConfig' var indicates if the caller is glXChooseFBConfig or
> glXChooseVisual.  The attributes in question are only valid for the former, not
> the later.

Ahh, my mistake, apologies.

This looks good to me then.

Thanks

Jon

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.