[Mesa-dev] Is it a memory leak?

[Zhenbo Xu]

Thank you for your replies!

在 2011年7月12日 下午10:47，Brian Paul <brianp at vmware.com>写道：

> On 07/12/2011 08:40 AM, Zhenbo Xu wrote:
> > I found the following bugs in mesa(v100) for SPEC CPU2000 v1.3
> >
> > leak bug 1:
> > //in file textimage.c at line 345
> > gl_text_image* image_to_texture(...) {
> > ...
> > textImage = gl_alloc_texttrue_image(...);
> > if (!textImage)
> > return NULL;
> > ...
> > switch (image->Type) {
> > case ...
> > ...
> > default:
> > gl_problem(...)
> > return NULL; //here without releasing textImage
> > }
> > }
> >
> > leak bug 2:
> > //in file osmesa.c at line 263
> > osmesa = (OSMesaContext) calloc( 1, sizeof(struct osmesa_context) );
> > 262 if (osmesa) {
> > osmesa->gl_visual = gl_create_visual( rgbmode, 264 swalpha,
> > DEPTH_BITS16,
> > STENCIL_BITS8,
> > ACCUM_BITS16,
> > index_bits,
> > rscale, gscale, bscale, ascale,
> > 8, 8, 8, 0 );
> > if (!osmesa->gl_visual) {
> >
> > return NULL((void*)0);//without releasing osmesa
> > }
> >
> > leak bug 3:
> > //in file drawpix.c at line 1010
> > void gl_DrawPixels(...) {
> > ...
> > if (ctx->CallDepth == 0) {
> > image = gl_unpack_pixels( ctx, width, height, format, type, pixels );
> > ...
> > }
> > ...
> > if (ctx->ExecuteFlag) { //Taking false branch
> > gl_save_DrawPixels( ctx, width, height, format, type, image );
> > }
> > if (ctx->ExecuteFlag) { //Taking false branch
> > ....
> > }//Without releasing image
> > }
> >
> > Is it suitable to report these bugs here?
>
>
> The Mesa code you're referring to is very old (circa 1999, I think).
> Taking a quick look, I don't think these leaks currently exist in Mesa
> today.
>
> > I also sent it to support at spec2000, but didn't have any response.
> > I'll be glad if you can check these bugs,
> > Or do I have another way to report them?
> > Thank you!
>
> I doubt that the SPEC organization is concerned with bugs in spec2000
> anymore either since it was retired in 2007.
>
> -Brian
>



-- 
Zhenbo Xu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110712/6da3d315/attachment.htm>