[Mesa-dev] [PATCH 03/12] intel: Move intel_draw_buffers() code into each driver.

Chad Versace chad at chad-versace.us
Wed Jul 13 16:04:49 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07/12/2011 03:22 PM, Eric Anholt wrote:
> The illusion of shared code here wasn't fooling anybody. It was
> tempting to keep i830 and i915 still shared, but I think I actually
> want to make them diverge shortly.
> ---
>  src/mesa/drivers/dri/i915/i830_vtbl.c      |  202 ++++++++++++++++++++++++++++
>  src/mesa/drivers/dri/i915/i915_vtbl.c      |  200 +++++++++++++++++++++++++++
>  src/mesa/drivers/dri/i965/brw_vtbl.c       |  201 +++++++++++++++++++++++++++
>  src/mesa/drivers/dri/intel/intel_buffers.c |  199 ---------------------------
>  src/mesa/drivers/dri/intel/intel_buffers.h |    9 +-
>  src/mesa/drivers/dri/intel/intel_context.h |    1 +
>  6 files changed, 612 insertions(+), 200 deletions(-)

All that illusion did was make a mess of everything. I'm glad to see this cleaned up.

Reviewed-by: Chad Versace <chad at chad-versace.us>

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOHiSRAAoJEAIvNt057x8i70QP/2aV9a4Uawijl6K17ukB/HlU
Lz83wSb3hr2fFStedscWAiYg+dVK+aa2ofOOpQqiZXXMlx8/bth1EMhXBK5gQCo3
46iqtf/sbtqqWegTXsQ3MEV5iUFf9ujp7VzICTBojcvoFwhDtYqOyNRbJXvlAcjf
eu3V5ck1/hc8HnMTcgcMa2zaxVIFCnKgx+IWs69gTxnQzzyM97Vc9s2yfbb8VmOq
hJ0MoEQRVq2PV11YjN314cY2oTtGrqTFFkWm2zM4w9IAhl8aU+gdoQzpPTgwt2g2
OYEJnFMPB0ydxoC5fGXsy4R1XXMvNUwe29aVXNwS1sGr6CcFW5bvunQzMJZ3Ru+q
OGtdYrBopSeg9Lj2jh5/e14uRInceIiSzLJz/om+1XGXgEZ+slboxGDzzFnVcqTG
Ud68uojNDvRtcpySMqM/4jhuR0z9dJE0Jh55EXxRg1SBfc6Bd02mgrfh9qMO8YS7
bouPVwzSeao66zytxPk4dd7Q+xLnntSHjrgfvkjyyYjgcmUGn54HBsIfAsx0cQHe
7b+Zc3m+Sn+BX5CvmZiHNVSsVkgSFjyY8xBtmiHNA5R8QbMw+0KgeBRIWkIRvdE9
fiYkBfZibR4LoNlGt8kUeZA2EboOJ6rH6nEQKo6NDllfN14uqrWScvDH5ysC5B48
r6jFrnFBAivuZTZRxuXu
=UCEa
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list