[Mesa-dev] [PATCH] g3dvl: check for existence of header/libs

[★ Emeric]

2011/7/14 Christian König <deathsimple at vodafone.de>:
> Hi Emeric,
>
> thanks for the tip, I've added "xorg-server" development files to the
> dependencies list and pushed it.
>
> I've just take a look over your VP8 code, looks quite good so far, just
> some side notes:
> 1.) regarding the picture parameter to decode_bitstream: Don't hack
> around my bugs, just leave me a note so I can fix them. This parameter
> should be of type pipe_picture_desc indeed, not
> pipe_mpeg12_picture_desc.
Yes I should not have done it this way, I was just trying to make it
build. A proper fix is needed for the same thing in other places.

> 2.) regarding VL_MAX_REF_FRAMES: Try to avoid defining a
> VP8_VL_MAX_REF_FRAMES, just increase the value currently there. If
> that's breaking something then leave me a note to fix it.
Just increasing VL_MAX_REF_FRAMES is probably not going to break
anything but the mpeg2 decoder would then have unused motion vectors
processed at different places.

These defines are mostly applying to the mpeg2 decoder, so it makes
sense to create more defines I guess ?
VL_MAX_REF_FRAMES : H.264 can have 16, VP8 4, mpeg1/2 divx and vc1 can have 2.
BLOCK_WIDTH : Block size is 8x8 for for some mpeg codecs, VP8 uses 8x8
and H.264 can have 8x8 and 4x4 at the same time.
VL_MAX_PLANES : H.264 can have only one plane when using 4:0:0
"monochrome" subsampling.

> Don't hesitate to ask if you have any questions.
Thanks. I am still trying to get libav to send the VP8 data through
VDPAU, but as soon as I dive into the vp8 decoder I will have a lot of
questions for sure ;-)

Cheers,
Emeric

> Regards,
> Christian.
>
> Am Donnerstag, den 14.07.2011, 15:17 +0200 schrieb ★ Emeric:
>> Hi Christian,
>> I don't know if that deserve a check in the autoconf, but the XvMC
>> state tracker requires this #include <xorg/fourcc.h> from the xorg
>> server development package.
>> Someone had the problem on the #mesa-devel channel, and could not get
>> mesa to build with --enable-xvmc because of it, so I guess this is a
>> new dependency.
>>
>> Emeric
>>
>> 2011/7/14 Christian König <deathsimple at vodafone.de>
>> >
>> > Hello list,
>> >
>> > I'm about to commit the attached patches, they add checks that the
>> > correct development packages are installed before enabling the different
>> > state trackers.
>> >
>> > Since me and autoconf are in a fight for several years now please take a
>> > look and check that I'm not doing anything stupid.
>> >
>> > Christian.
>> >
>> > _______________________________________________
>> > mesa-dev mailing list
>> > mesa-dev at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>> >
>
>
>