[Mesa-dev] Common Subexpression Elimination

[Bryan Cain]

On 07/16/2011 10:28 AM, Vincent wrote:
> Hi,
>
> I wrote an optimisation pass that perform CSE (that is, it spots
> expressions that appears twice or more, and factor them in a temporary
> to avoid recalculation).
> This is my first patch to Mesa, I would like to receive feedback :
> case where the algorithm does not work, crashes, ...
> I tried to follow coding style, using exec_list*, ralloced objects...
> The algorithm currently only spot binary expressions (that is x + y, x
> * y, ...) but unary expression (exp(x), ln(x)...) should follow soon.
>
> Regards,
> Vincent.

Hi Vincent,

For future reference, the diff you sent is currently reversed - the
lines you added are marked as "-" and the lines you removed are marked
as "+".  It's best if you send patches using git-send-email to avoid this.

Bryan