[Mesa-dev] [Intel-gfx] [PATCH 04/10] i965: setup system routine

[Ben Widawsky]

On Mon, Jul 18, 2011 at 11:19:17AM -0700, Eric Anholt wrote:
> On Sun, 17 Jul 2011 16:25:42 -0700, Ben Widawsky <ben at bwidawsk.net> wrote:
> > Upload the system routine as part of the invariant state if debugging.
> > 
> > Remove SIP setting if not debugging to make it more friendly for others
> > that may be debugging shaders or media kernels.
> > 
> > v2: removed comment per Chris
> 
> This patch doesn't really make sense to me.  Nothing good will come of
> my driver's buffer execution landing inside someone else's debug kernel,
> right?  So why should my driver's batchbuffer be leaving their SIP in
> place?

Yeah you're right. Furthermore, the default value should be 0, which should be
all good all around. Initially I was trying to do something fancier here,
detecting when the SIP has been changed external to mesa, but I gave up on
that.

I will remove the condition and always set sip.

Ben

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110719/b19e50de/attachment.pgp>