[Mesa-dev] [PATCH 1/2] st/mesa: respect force_s3tc_enable environment variable

[Bryan Cain]

On 07/21/2011 08:48 AM, Brian Paul wrote:
> On 07/20/2011 04:53 PM, Bryan Cain wrote:
>> ---
>>   src/mesa/state_tracker/st_extensions.c |   12 +++++++++++-
>>   1 files changed, 11 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/mesa/state_tracker/st_extensions.c
>> b/src/mesa/state_tracker/st_extensions.c
>> index 99b231d..073e72c 100644
>> --- a/src/mesa/state_tracker/st_extensions.c
>> +++ b/src/mesa/state_tracker/st_extensions.c
>> @@ -208,6 +208,16 @@ void st_init_limits(struct st_context *st)
>>   }
>>
>>
>> +static int st_get_s3tc_override(void)
>> +{
>> +   const char *override = _mesa_getenv("force_s3tc_enable");
>> +   fprintf(stderr, "force_s3tc_enable=%s\n", override);
>
> This fprintf() looks like left-over debug code.

Oops, you're right.

>
>> +   if (override&&  !strcmp(override, "true"))
>> +      return GL_TRUE;
>> +   return GL_FALSE;
>
> If you're going to return GL_TRUE/GL_FALSE, the function type should
> be GLboolean.

Okay, I'll resubmit the patch with those changes.

Bryan