[Mesa-dev] [PATCH 10/13] i965: When emitting a src/dst read of an output, keep the swizzle and neg

Ian Romanick idr at freedesktop.org
Thu Jul 21 12:16:55 PDT 2011


From: Ian Romanick <ian.d.romanick at intel.com>

Fixes i965 piglit vs-varying-array-mat[234]-row-rd.
---
 src/mesa/drivers/dri/i965/brw_vs_emit.c |   17 +++++++++++++++--
 1 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_vs_emit.c b/src/mesa/drivers/dri/i965/brw_vs_emit.c
index 5ef8b07..e226d84 100644
--- a/src/mesa/drivers/dri/i965/brw_vs_emit.c
+++ b/src/mesa/drivers/dri/i965/brw_vs_emit.c
@@ -1980,9 +1980,22 @@ void brw_vs_emit(struct brw_vs_compile *c )
 	      const struct prog_src_register *src = &inst->SrcReg[i];
 	      index = src->Index;
 	      file = src->File;	
-	      if (file == PROGRAM_OUTPUT && c->output_regs[index].used_in_src)
+	      if (file == PROGRAM_OUTPUT && c->output_regs[index].used_in_src) {
+		 /* Can't just make get_arg "do the right thing" here because
+		  * other callers of get_arg and get_src_reg don't expect any
+		  * special behavior for the c->output_regs[index].used_in_src
+		  * case.
+		  */
 		  args[i] = c->output_regs[index].reg;
-	      else
+		  args[i].dw1.bits.swizzle =
+		     BRW_SWIZZLE4(GET_SWZ(src->Swizzle, 0),
+				  GET_SWZ(src->Swizzle, 1),
+				  GET_SWZ(src->Swizzle, 2),
+				  GET_SWZ(src->Swizzle, 3));
+
+		  /* Note this is ok for non-swizzle ARB_vp instructions */
+		  args[i].negate = src->Negate ? 1 : 0;
+	      } else
                   args[i] = get_arg(c, inst, i);
 	  }
 
-- 
1.7.4.4



More information about the mesa-dev mailing list