[Mesa-dev] [PATCH] i965/fs: Clear result before visiting shadow comparitor and LOD info.

Eric Anholt eric at anholt.net
Fri Jul 22 09:21:03 PDT 2011

On Thu, 21 Jul 2011 22:23:42 -0700, Kenneth Graunke <kenneth at whitecape.org> wrote:
> Commit 53c89c67f33639afef951e178f93f4e29acc5d53 ("i965: Avoid generating
> MOVs for assignments of expressions.") added the line "this->result =
> reg_undef" all over the code.  Unfortunately, since Eric developed his
> patch before I landed Ivybridge support, he missed adding it to
> fs_visitor::emit_texture_gen7() after rebasing.
> Furthermore, since I developed TXD support before Eric's patch, I
> neglected to add it to the gradient handling when I rebased.
> Neglecting to set this causes the visitor to use this->result as storage
> rather than generating a new temporary.  These missing statements
> resulted in the same register being used to store several different
> values.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110722/d5d35652/attachment.pgp>

More information about the mesa-dev mailing list