[Mesa-dev] [PATCH] gallium/softpipe: Don't clobber dest color/alpha before masking.

Younes Manton younes.m at gmail.com
Sat Jul 23 14:14:29 PDT 2011


On Fri, Jul 22, 2011 at 10:00 AM, Brian Paul <brianp at vmware.com> wrote:
> On 07/21/2011 06:59 PM, Younes Manton wrote:
>>
>> The blend_quad function clobbers the actual render target color/alpha
>> values while applying the destination blend factor, which results in
>> restoring the wrong value during the masking stage for write-disabled
>> channels.
>> ---
>>  src/gallium/drivers/softpipe/sp_quad_blend.c |  185
>> +++++++++++++------------
>>  1 files changed, 96 insertions(+), 89 deletions(-)
>
>
> Reviewed-by: Brian Paul <brianp at vmware.com>
>
> It would be nice to have piglit test to catch this case.
>
> -Brian
>

I'll add one shortly.


More information about the mesa-dev mailing list