[Mesa-dev] [Bug 39307] vdpau advertises support for MPEG1, but it's unimplemented

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39307

--- Comment #4 from Andy Furniss <lists at andyfurniss.entadsl.com> 2011-07-25 05:00:05 PDT ---
(In reply to comment #2)
> Mhm, Emeric you patch looks quite right to me.
> 
> But honestly, I couldn't find an MPEG1 to test it.Emeric you patch looks quite
> right to me.
> 
> But honestly, I couldn't find an MPEG1 to test it.

http://www.linux-video.net/Samples/Mpeg1/

> 
> So could anybody please confirm that it's right so we can push it?

Works OK for me on rv790 (OK meaning rendering with same issues as mpeg2), only
tested the space shuttle vid from above.

Had to edit by hand as master seems to have changed somewhat - for reference
here's the diff I tested with.

diff --git a/src/gallium/state_trackers/vdpau/decode.c
b/src/gallium/state_trackers/vdpau/decode.c
index 269c7a4..931d62b 100644
--- a/src/gallium/state_trackers/vdpau/decode.c
+++ b/src/gallium/state_trackers/vdpau/decode.c
@@ -161,7 +161,7 @@ vlVdpDecoderGetParameters(VdpDecoder decoder,
 }

 static VdpStatus
-vlVdpDecoderRenderMpeg2(struct pipe_video_decoder *decoder,
+vlVdpDecoderRenderMpeg12(struct pipe_video_decoder *decoder,
                         struct pipe_video_decode_buffer *buffer,
                         struct pipe_video_buffer *target,
                         VdpPictureInfoMPEG1Or2 *picture_info,
@@ -256,11 +256,12 @@ vlVdpDecoderRender(VdpDecoder decoder,

    // TODO: Right now only mpeg2 is supported.
    switch (vldecoder->decoder->profile)   {
+   case PIPE_VIDEO_PROFILE_MPEG1:
    case PIPE_VIDEO_PROFILE_MPEG2_SIMPLE:
    case PIPE_VIDEO_PROFILE_MPEG2_MAIN:
       ++vldecoder->cur_buffer;
       vldecoder->cur_buffer %= VL_NUM_DECODE_BUFFERS;
-      return vlVdpDecoderRenderMpeg2(vldecoder->decoder,
+      return vlVdpDecoderRenderMpeg12(vldecoder->decoder,
                                      vldecoder->buffer[vldecoder->cur_buffer],
                                      vlsurf->video_buffer,
                                      (VdpPictureInfoMPEG1Or2 *)picture_info,

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.