[Mesa-dev] [PATCH 1/1] mesa: Call updated_drawbuffers() if the buffer count changes in _mesa_drawbuffers().

[Henri Verbeet]

On 26 July 2011 02:21, Ian Romanick <idr at freedesktop.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 07/25/2011 01:23 PM, Henri Verbeet wrote:
>> Without this we'd miss an update when doing a sequence like {COLOR0, COLOR1},
>> {COLOR0}, {COLOR0, COLOR1}.
>
> Is there a piglit test to reproduce this failure?
>
No, I found this using the Wine D3D tests. I can easily write one though.

On 26 July 2011 04:29, Eric Anholt <eric at anholt.net> wrote:
> Ah, I see.  I like this better than setting remaining buffers to NONE.
> (and with this patch, we could avoid doing so, right?).
>
Yeah. As a follow up we can probably also get rid of setting the
remaining buffers to NONE in the n != 1 path, unless there's code that
doesn't check _NumColorDrawBuffers. Such code would currently break on
the n == 1 path as well though.