[Mesa-dev] [PATCH 4/4] glsl: Fix implicit conversions in array constructors

Chad Versace chad at chad-versace.us
Tue Jul 26 23:36:02 PDT 2011

Array constructors obey narrower conversion rules than other constructors,
but process_array_constructor() was incorrectly applying the broader
rules. From page 33 (page 39 of the pdf) of the GLSL 1.20 spec, Section
5.4.4 Array Constructors:
    Each argument must be the same type as the element type of the array,
    or be a type that can be converted to the element type of the array
    according to Section 4.1.10 “Implicit Conversions.”

Fixes Piglit

If cherry-picked, the following commits are required:
    glsl: Refactor ast_function.cpp:type_compare() into a glsl_type method
    glsl: Fix illegal implicit type conversions

Note: This is a candidate for the 7.10 and 7.11 branches.
CC: Ian Romanick <ian.d.romanick at intel.com>
Signed-off-by: Chad Versace <chad at chad-versace.us>
 src/glsl/ast_function.cpp |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index bdb73f4..77c236f 100644
--- a/src/glsl/ast_function.cpp
+++ b/src/glsl/ast_function.cpp
@@ -448,7 +448,9 @@ process_array_constructor(exec_list *instructions,
-	 result = convert_component(ir, desired_type);
+	 if (ir->type->implicit_conversion_compare(desired_type) >= 0) {
+	    result = convert_component(ir, desired_type);
+	 }
       if (result->type != constructor_type->element_type()) {

More information about the mesa-dev mailing list