[Mesa-dev] [PATCH 3/3] glsl: Fix illegal implicit type conversions in type_compare()

Chad Versace chad at chad-versace.us
Tue Jul 26 23:38:48 PDT 2011

On 07/26/2011 05:43 PM, Ian Romanick wrote:
> On 07/26/2011 04:08 PM, Chad Versace wrote:
>> type_compare() allowed the following illegal implicit conversions:
>>     bool -> float
>>     bvecN -> vecN
>> Fixes Piglit tests
>> spec/glsl-1.20/compiler/built-in-functions/outerProduct-bvec*.vert.
> Does this also fix array-ctor-implicit-conversion-bvec[234]-vec[234]?
> It occurred to me the other day that these failures are probably related.

Those two sets of tests take very different code paths in doing the
implicit conversions. They are not related.

Nak this patch series. I've posted a new one that fixes both test sets.

Chad Versace
chad at chad-versace.us

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 900 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20110726/3380ac9b/attachment.pgp>

More information about the mesa-dev mailing list