[Mesa-dev] Gallium interface little cleanup
keithw at vmware.com
Fri Mar 11 08:48:45 PST 2011
> I have done some of the changes in the gallium interface we discussed
> in the
> thread called "7 questions...".
> There are 4 patches in total:
> 1) gallium: kill is_resource_referenced
> The function is_resource_referenced is removed. Considering that only
> st/xorg used it, I don't think this can cause any regressions in
> drivers. However softpipe and llvmpipe use it internally, so I have
> kept it
> there and added driver-specific flags instead:
> #define LP_UNREFERENCED 0
> #define LP_REFERENCED_FOR_READ (1 << 0)
> #define LP_REFERENCED_FOR_WRITE (1 << 1)
> The same for softpipe (SP_*).
> 2) gallium: cleanup fence_signalled and fence_finish
> This removes the "flags" parameter from both the functions and changes
> return type to boolean (TRUE=success).
> 3) gallium: remove the geom_flags param from is_format_supported
> This was unused anyway.
> 4) gallium: remove flags from the flush function
> The drivers have been changed so that they behave as if all of the
> were set (if used at all). This is already implicit in most hardware
> and required for multiple contexts anyway (besides maybe SWAPBUFFERS
> FRAME, the exact meaning of which is undefined). Some state trackers
> also abusing the PIPE_FLUSH_RENDER_CACHE flag to decide whether
> flush_frontbuffer should be called. New flag ST_FLUSH_FRONT has been
> to st_api.h as a replacement, since the PIPE_FLUSH_* flags no longer
> The patches are here (they are too large to be posted on ML):
> Please review.
It all looks & sounds good to me.
More information about the mesa-dev