[Mesa-dev] Fix for bug #35073

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/11/2011 05:49 PM, Eric Anholt wrote:
> Here's a proposed fix for bug #35073, but I'd like some review.  From
> googling, it looks like we're not the first driver to stumble on this.
> Here's the note from the bug reporter:
> 
> 	The OpenGL spec looks a little unclear to me - it says the
> 	alpha test "applies only in RGBA mode, and only if the color
> 	buffer has a fixed-point or floating-point format", but I
> 	don't see what it wants if there is no color buffer. I think
> 	the most useful and compatible behaviour would be to apply the
> 	alpha test in this case and to compute the correct alpha value
> 	first.
> 
> I'm agreeing with the reporter here with this patch series.

I think that's correct.  I've submitted an OpenGL spec bug.  We clearly
didn't consider this case when we were creating framebuffer objects.

In any case, for the whole series:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk1+gFkACgkQX1gOwKyEAw/mFQCfbqPwrcdfGnOcuwEGhEQ8dRML
1sEAoJ1p13QWYrHJ4zb/bFllTYWlgIP/
=JiOP
-----END PGP SIGNATURE-----