[Mesa-dev] Mesa (master): i965: Fix tex_swizzle when depth mode is GL_RED

[Chad Versace]

On 03/14/2011 05:15 PM, Ian Romanick wrote:
> On 03/14/2011 01:04 PM, Kenneth Graunke wrote:
>> Module: Mesa
>> Branch: master
>> Commit: 1842b89f77bb7bd283b61e27cd69c643f2a60a22
>> URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1842b89f77bb7bd283b61e27cd69c643f2a60a22
> 
>> Author: Chad Versace <chad.versace at intel.com>
>> Date:   Sat Mar 12 17:49:41 2011 -0800
> 
>> i965: Fix tex_swizzle when depth mode is GL_RED
> 
>> Change swizzle from (x000) to (x001).
> 
> I don't think we need 1.30 to hit this path (just GL_ARB_texture_rg?).

We just need ARB_texture_rg. The Piglit test cases are written in GLSL 1.10.

> Do we have a test case? 

Ken, you stripped the test case reference from the commit message!

For this commit [i965: Fix tex_swizzle when depth mode is GL_RED], see
test cases piglit:spec/arb_texture_rg/execution/fs-shadow2d-red-*. For
the subsequent commit [i965: Enable texture lookups whose return type is
'float'], see test cases
piglit:spec/glsl-1.30/execution/fs-texture-sampler2dshadow-*.

> Should this be a stable-branch candidate?

Yes.

-- 
Chad Versace
chad at chad-versace.us