[Mesa-dev] Truncated extensions string

Ian Romanick idr at freedesktop.org
Tue Mar 15 13:26:58 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 03/15/2011 08:29 AM, José Fonseca wrote:
> Attached is a new version of the patch that keeps the extensions sorted
> alphabetically in the source code, and sorts chronologically in runtime.
> (Note the patch doesn't apply against the tip of master, but a version a
> few weeks old -- I'll update before committing to master.) 

I don't see how this fixes the problem, so perhaps I'm misunderstanding
the problem.  Don't these buggy apps still get an extension string
that's longer than they know how to handle?  That's why Ken mentioned
the use of an environment variable so that the app only ever sees, for
example, the extensions that existed before 2003.

After all, the apps that aren't smart enough to dynamically allocate a
buffer probably also aren't smart enough to use strncmp *and* add a NUL
terminator to the string.

Right?

> Also attached is a patch for glxinfo that sorts all extensions
> alphabetically.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEUEARECAAYFAk1/y5IACgkQX1gOwKyEAw9lNQCXcbV58soOTcSu11g6YTRW9JLH
4wCdFwS1DKqkeJlZVXZpYxuyjE7fPws=
=SGSx
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list