[Mesa-dev] [PATCH 2/6] gallium: implement clamping controls (ARB_color_buffer_float)

[Christoph Bumiller]

On 03/21/2011 02:12 AM, Marek Olšák wrote:

> diff --git a/src/gallium/include/pipe/p_state.h b/src/gallium/include/pipe/p_state.h
> index cf6c5b5..f6ad456 100644
> --- a/src/gallium/include/pipe/p_state.h
> +++ b/src/gallium/include/pipe/p_state.h
> @@ -81,6 +81,8 @@ struct pipe_rasterizer_state
>  {
>     unsigned flatshade:1;
>     unsigned light_twoside:1;
> +   unsigned clamp_vertex_color:1;
> +   unsigned clamp_fragment_color:1;
>     unsigned front_ccw:1;
>     unsigned cull_face:2;      /**< PIPE_FACE_x */
>     unsigned fill_front:2;     /**< PIPE_POLYGON_MODE_x */

Hadn't you put clamp_fragment_color in the blend state initially ?
It seems like a more logical place to me.

Beyond that I don't mind where it ends up though, both CSOs are growing
a little too large for my taste.

Christoph