[Mesa-dev] [PATCH 2/3] glsl: Calcluate Mesa state slots in front-end instead of back-end

Chad Versace chad at chad-versace.us
Fri Mar 25 11:56:06 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

One tiny fix...

> +   unsigned i;
> +   for (i = 0; _mesa_builtin_uniform_desc[i].name != NULL; i++) {
> +      if (strcmp(_mesa_builtin_uniform_desc[i].name, name) == 0) {
> +	 break;
> +      }
> +   }
> +
...
> +   for (unsigned a = 0; a < array_count; a++) {
> +      for (unsigned i = 0; i < statevar->num_elements; i++) {

The second 'unsigned i' shadows the first. Maybe rename it to 'j'?

- -- 
Chad Versace
chad at chad-versace.us
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJNjOVGAAoJEAIvNt057x8ipNcP/10u5W4/87Ci4emgpGOTRX5U
tyRNpWrdht+n/VoEZwB9jM4t5Ew7grQoUT5yDEUzCjGhxppRnylemRnjW2Ji/G9j
wRTWBS33e+3WI/e4BjjTx/Lz13VqclIMztwQ5kumqlip9O6aljuhMmAjcpKI5aVr
nXQASH+jAPPNhqf65LDCN2J90pdnh1Z9gKx8vrA9HvkpRBvha8EvuKKZ5ehABZ/p
43tHUpMcaeoKB4V65dpYF3T/uWcNp6gxv+3KMJ8T+52CzTcOmKZEff0iZQRFksyd
D0K7X0a1NrBe0VkRSX/cDaNUQbtOWP3o7FjR5/dXV2d4nvTN8YGVLkD2sNwwqfaG
RxDcU8BExTwZGZ1yQlVk91043wz2tJV31rhlqlfxVFW9yBWjjxfzBKPUFTeMCDA3
tc08qqGdwws3kI1EdRKyTVAKED7qocOZuiOymlN1Zhkr3CkN9xxnauHe7FFWtfnB
vqdXFe14KIxWfCW26C7K5RSG/nCD3950As+SAAYr1gd5k/+Fn0yXp+jhfeblbbE5
UE2nAZcZNKKmOdkN/FFRLSgGMVr5UEjgfW7PbHpQuLRtT3W3H1Pd7GucPg27yBkl
EMCdjQlcGJn7PwAzWymSDNLxd2Cnn/jn9qEtZ+5aK710MQB17O3pPGI2urnt2yDv
0SY3aVQd80Urp/En5gGH
=ZnoP
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list