[Mesa-dev] [PATCH] gallium/xorg st/nv50/i915: add PIPE_BIND_CURSOR

Daniel Vetter daniel at ffwll.ch
Mon May 2 06:11:00 PDT 2011


On Mon, May 2, 2011 at 2:56 PM, Benjamin Franzke
<benjaminfranzke at googlemail.com> wrote:
> I think in i915g the CURSOR flag should be used in i9x5_scanout_layout
> for the "special case for cursors" as well, instead of only checking
> only pt->width0 == 64 && pt->height0 == 64.

Oops, so much for actually re-checking the code. On the other hand, that
part is broken, it needs a
   tex->tiling = I915_TILE_NONE;
and perhaps some check that width == height == 64 indeed holds. Then
move it out as the first if clause and it'd start to make sense ...
-Daniel
-- 
Daniel Vetter
daniel.vetter at ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch


More information about the mesa-dev mailing list