[Mesa-dev] [PATCH 2/6] gallium: implement ARB_seamless_cube_map

Ian Romanick idr at freedesktop.org
Mon May 2 10:02:17 PDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/02/2011 06:47 AM, Brian Paul wrote:
> On 05/02/2011 07:03 AM, Marek Olšák wrote:
>> ---
>> diff --git a/src/gallium/include/pipe/p_state.h
>> b/src/gallium/include/pipe/p_state.h
>> index 0c1f509..26e8a8e 100644
>> --- a/src/gallium/include/pipe/p_state.h
>> +++ b/src/gallium/include/pipe/p_state.h
>> @@ -101,6 +101,7 @@ struct pipe_rasterizer_state
>>      unsigned line_smooth:1;
>>      unsigned line_stipple_enable:1;
>>      unsigned line_last_pixel:1;
>> +   unsigned seamless_cube_map:1;
> 
> Shouldn't this be sampler state and not rasterizer state?  The AMD
> extension lets this option be set per texture.  Though, I don't know if
> non-AMD hardware supports that mode.

On NVIDIA does not support that mode.  That's the only reason that
ARB_seamless_cube_map is global state.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk2+45kACgkQX1gOwKyEAw9kXQCghuGIzyfl99jundUogQvhg2Aq
LN0Ani50mQZDec367lM/Z5XYF0D9VtLV
=X3JO
-----END PGP SIGNATURE-----


More information about the mesa-dev mailing list