[Mesa-dev] [PATCH 1/6] mesa: add and use a dirty flag for GL_TEXTURE_CUBE_MAP_SEAMLESS

[Ian Romanick]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 05/02/2011 08:29 AM, Marek Olšák wrote:
> On Mon, May 2, 2011 at 3:47 PM, Brian Paul <brianp at vmware.com> wrote:
>> On 05/02/2011 07:03 AM, Marek Olšák wrote:
>>>
>>> Otherwise there would be no way to know whether the state has been
>>> changed.
>>> ---
>>>  src/mesa/main/enable.c |    1 +
>>>  src/mesa/main/mtypes.h |    1 +
>>>  2 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/src/mesa/main/enable.c b/src/mesa/main/enable.c
>>> index 2ec19c8..dbc6d21 100644
>>> --- a/src/mesa/main/enable.c
>>> +++ b/src/mesa/main/enable.c
>>> @@ -886,6 +886,7 @@ _mesa_set_enable(struct gl_context *ctx, GLenum cap,
>>> GLboolean state)
>>>        case GL_TEXTURE_CUBE_MAP_SEAMLESS:
>>>         CHECK_EXTENSION(ARB_seamless_cube_map, cap);
>>>         ctx->Texture.CubeMapSeamless = state;
>>> +        FLUSH_VERTICES(ctx, _NEW_SEAMLESS_CUBE_MAP);
>>>         break;
>>
>> The flush call needs to be made before the state is changed.
> 
> OK, please see the attached patch (replaces [PATCH 1/6]).
> 
> The second attached patch fixes the same problem in the place where I
> got that from.
> 
> The third attached patch just renames _NEW_SEAMLESS_CUBE_MAP to
> _NEW_TEXTURE in st/mesa (replaces [PATCH 2/6]).
> 
> Please review.

5/6 and 6/6 of the original series and 1/3 and 2/3 of this series:

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk2+5nkACgkQX1gOwKyEAw/LygCfUpHmTJ3akPRxRVwt2tNxnVmv
T1IAoJHXQ5iFlgRXBOmzWHBXHlsXzRRD
=8AQn
-----END PGP SIGNATURE-----