[Mesa-dev] [RFC] swap complete event handling fixes

[Jesse Barnes]

On Tue, 03 May 2011 11:38:26 -0700
Ian Romanick <idr at freedesktop.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 05/03/2011 10:59 AM, Jesse Barnes wrote:
> > Ended up moving over to generic events since the GLX type code is part
> > of the GLX namespace and larger than 8 bits.
> > 
> > Apparently no one had ever tried ChangeDrawableAttributes with indirect
> > clients, because simply going a glXSelectEvent causes a crash in that
> > case.  So this patch set includes a fix for that issue and has been
> > tested with both direct and indirect clients, both with and without
> > client and server support.
> > 
> > New clients with old servers should get a 0 sbc rather than garbage.
> > New servers will send old clients a 0 sbc, but the clients will still
> > copy garbage into the event actually sent to clients.  New servers with
> > new clients should work both in the direct and indirect cases and get
> > whatever values the server sends for each field.
> > 
> > As always, testing and review appreciated.  Piglit's glx-swap-event case
> > now checks for swap count sanity (i.e. increasing, nonzero value) and
> > allows you to dump the current values in verbose mode.  I also added a
> > few more return value checks to the test.
> 
> I assume there will also be updates to the GLX_INTEL_swap_event
> extension spec?

Wait wtf; the spec has a 32 bit sbc count to fit inside XEvent, but
when it was changed we never updated the code?  That would certainly
make things easier, since we wouldn't need any proto bumping.

-- 
Jesse Barnes, Intel Open Source Technology Center