[Mesa-dev] [PATCH] glxproto: make GLX swap event struct match spec
jbarnes at virtuousgeek.org
Tue May 3 14:02:31 PDT 2011
On Tue, 03 May 2011 13:54:38 -0700
Keith Packard <keithp at keithp.com> wrote:
> On Tue, 3 May 2011 12:21:24 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > We only spec a 32 bit swap count, so drop the high sbc field.
> You're missing the explicit 16-bit padding field after 'event_type'
> The documented encoding
> http://www.opengl.org/registry/specs/INTEL/swap_event.txt needs to be
> fixed to match this, it has the padding at the end which leaves most of
> the structure mis-aligned.
Right, another case where we updated the spec incorrectly then failed
to make the code match the broken definition (the complete enums also
need to match the final values, which are correct in the first part of
the spec). Yay for divergence.
Jesse Barnes, Intel Open Source Technology Center
More information about the mesa-dev